lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag
From
Date
Hi Tom,

On 11/14/20 9:53 AM, Tom Rix wrote:
>
> On 11/14/20 6:30 AM, Richard Gong wrote:
>>
>>> A whitespace issue, the new BIT(5) should align with the others, so add two spaces to the others.
>>>
>>
>> There is only one space, also I ran checkpatch with strict option and didn't see any whitespace issue.
>>
>> In the original patch, BIT(0) to BIT(4) align themselves. I am not sure why we see differently in email.
>>
>>  #define FPGA_MGR_PARTIAL_RECONFIG      BIT(0)
>>  #define FPGA_MGR_EXTERNAL_CONFIG       BIT(1)
>>  #define FPGA_MGR_ENCRYPTED_BITSTREAM   BIT(2)
>>  #define FPGA_MGR_BITSTREAM_LSB_FIRST   BIT(3)
>>  #define FPGA_MGR_COMPRESSED_BITSTREAM  BIT(4)
>> +#define FPGA_MGR_BITSTREM_AUTHENTICATION BIT(5)
>>
>> To align BIT(5) with others, I have to use additional tab to BIT(0) to BIT(4). But I don't think I should make such change on them, agree?
>
> The existing table of #defines has aligned values for BIT(0) to BIT(4)
>
> Your addition of BIT(5) value has an inconsistent alignment with the others BIT(0) to BIT(4)
>
> The alignment of all the values should be consistent.
>

OK, I will make them all aligned.

Regards,
Richard

> Tom
>
>>
>> Regards,
>> Richard
>>
>>> Tom
>>>
>>>>     /**
>>>>    * struct fpga_image_info - information specific to a FPGA image
>>>
>>
>

\
 
 \ /
  Last update: 2020-11-16 14:20    [W:0.185 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site