lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 3/7] gpio: exar: switch to a simpler IDA interface
    Date
    From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

    We don't need to specify any ranges when allocating IDs so we can switch
    to ida_alloc() and ida_free() instead of the ida_simple_ counterparts.

    ida_simple_get(ida, 0, 0, gfp) is equivalent to
    ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to
    ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID
    larger than INT_MAX.

    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/gpio/gpio-exar.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
    index 1941ae533418..752e8437ff80 100644
    --- a/drivers/gpio/gpio-exar.c
    +++ b/drivers/gpio/gpio-exar.c
    @@ -149,7 +149,7 @@ static int gpio_exar_probe(struct platform_device *pdev)

    mutex_init(&exar_gpio->lock);

    - index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);
    + index = ida_alloc(&ida_index, GFP_KERNEL);
    if (index < 0) {
    ret = index;
    goto err_mutex_destroy;
    @@ -179,7 +179,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
    return 0;

    err_destroy:
    - ida_simple_remove(&ida_index, index);
    + ida_free(&ida_index, index);
    err_mutex_destroy:
    mutex_destroy(&exar_gpio->lock);
    return ret;
    @@ -189,7 +189,7 @@ static int gpio_exar_remove(struct platform_device *pdev)
    {
    struct exar_gpio_chip *exar_gpio = platform_get_drvdata(pdev);

    - ida_simple_remove(&ida_index, exar_gpio->index);
    + ida_free(&ida_index, exar_gpio->index);
    mutex_destroy(&exar_gpio->lock);

    return 0;
    --
    2.29.1
    \
     
     \ /
      Last update: 2020-11-16 11:46    [W:3.024 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site