Messages in this thread | | | Subject | Re: [PATCH v3] checkpatch: add fix option for MAINTAINERS_STYLE | From | Joe Perches <> | Date | Mon, 16 Nov 2020 20:29:45 -0800 |
| |
On Mon, 2020-11-16 at 20:26 -0800, Joe Perches wrote: > On Tue, 2020-11-17 at 09:35 +0530, Aditya Srivastava wrote: > > Checkpatch expects entries in MAINTAINERS file in a specific order and > > warns if the changes made do not follow the specified order. > > > > E.g., running checkpatch on commit b33bc2b878e0 ("nexthop: Add entry to > > MAINTAINERS") reports this warning: > > > > WARNING: Misordered MAINTAINERS entry - list file patterns in > > alphabetic order > > +F: include/uapi/linux/nexthop.h > > +F: include/net/netns/nexthop.h > > > > Provide a simple fix by swapping the unordered lines, if both the lines > > are additions (start with '+') > > On second thought, nak. > > This fails when there are 3 consecutive misordered lines. > > SECTION > F: c > F: b > F: a >
btw:
scripts/parse-maintainers.pl already does this reordering properly so this particular --fix addition isn't all that useful.
| |