lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 17/40] drm/meson/meson_vclk: Make two local functions static
From
Date
On 13/11/2020 14:49, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/meson/meson_vclk.c:134:6: warning: no previous prototype for ‘meson_vid_pll_set’ [-Wmissing-prototypes]
> drivers/gpu/drm/meson/meson_vclk.c:490:6: warning: no previous prototype for ‘meson_hdmi_pll_set_params’ [-Wmissing-prototypes]
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/meson/meson_vclk.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c
> index 0eb86943a3588..2a82119eb58ed 100644
> --- a/drivers/gpu/drm/meson/meson_vclk.c
> +++ b/drivers/gpu/drm/meson/meson_vclk.c
> @@ -131,7 +131,7 @@ enum {
> VID_PLL_DIV_15,
> };
>
> -void meson_vid_pll_set(struct meson_drm *priv, unsigned int div)
> +static void meson_vid_pll_set(struct meson_drm *priv, unsigned int div)
> {
> unsigned int shift_val = 0;
> unsigned int shift_sel = 0;
> @@ -487,9 +487,9 @@ static inline unsigned int pll_od_to_reg(unsigned int od)
> return 0;
> }
>
> -void meson_hdmi_pll_set_params(struct meson_drm *priv, unsigned int m,
> - unsigned int frac, unsigned int od1,
> - unsigned int od2, unsigned int od3)
> +static void meson_hdmi_pll_set_params(struct meson_drm *priv, unsigned int m,
> + unsigned int frac, unsigned int od1,
> + unsigned int od2, unsigned int od3)
> {
> unsigned int val;
>
>

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

\
 
 \ /
  Last update: 2020-11-16 09:51    [W:1.620 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site