Messages in this thread | | | Subject | Re: [PATCH] btrfs: remove the useless value assignment in btrfs_defrag_file | From | kaixuxia <> | Date | Tue, 17 Nov 2020 10:53:23 +0800 |
| |
On 2020/11/16 23:13, David Sterba wrote: > On Sat, Nov 14, 2020 at 05:06:21PM +0800, xiakaixu1987@gmail.com wrote: >> From: Kaixu Xia <kaixuxia@tencent.com> >> >> The variable ret is overwritten by the following variable defrag_count >> and this assignment is useless, so remove it. > > This could be actually pointing to a bug, please explain why you think > it's correct to remove it and not to return EAGAIN.
The right fix should be goto out_ra and return EAGAIN. I will do it in the next version.
Thanks, Kaixu >
-- kaixuxia
| |