Messages in this thread | | | From | Huacai Chen <> | Date | Tue, 17 Nov 2020 09:18:15 +0800 | Subject | Re: [PATCH 2/4] MIPS: kvm: Use vm_get_page_prot to get protection bits |
| |
Hi, Thomas,
On Mon, Nov 16, 2020 at 8:35 PM Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote: > > On Sat, Nov 14, 2020 at 03:34:14PM +0800, Huacai Chen wrote: > > Hi, Thomas, > > > > On Fri, Nov 13, 2020 at 7:13 PM Thomas Bogendoerfer > > <tsbogend@alpha.franken.de> wrote: > > > > > > MIPS protection bits are setup during runtime so using defines like > > > PAGE_SHARED ignores this runtime changes. Using vm_get_page_prot > > > to get correct page protection fixes this. > > Is there some visible bugs if without this fix? > > no exec isn't enabled for these mappings, if cpu supports it. The whole series wants to set XI if supported?
Huacai
Huacai
> > Thomas. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ]
| |