Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Fix unescaped left brace | From | Joe Perches <> | Date | Mon, 16 Nov 2020 15:02:36 -0800 |
| |
On Sun, 2020-11-15 at 19:43 -0800, Joe Perches wrote: > On Mon, 2020-11-16 at 01:59 +0530, Dwaipayan Ray wrote: > > There is an unescaped left brace in a regex in OPEN_BRACE > > check. This throws a runtime error when checkpatch is run > > with --fix flag and the OPEN_BRACE check is executed. > > > > Fix it by escaping the left brace. > > > > Fixes: 8d1824780f2f ("checkpatch: add --fix option for a couple OPEN_BRACE misuses") > > Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com> > > Thanks Dwaipayan. > > Obviously that code path hasn't been tested in awhile. > > I think the notice to require an escape for a { was added back in > perl 5.16 or so.
Just fyi: it seems the requirement was actually implemented in perl 5.22 and this code predates the release of perl 5.22
https://github.com/Perl/perl5/blob/blead/pod/perl5220delta.pod
| |