Messages in this thread | | | Subject | Re: [PATCH 32/42] drm/ttm/ttm_tt: Demote kernel-doc header format abuses | From | Christian König <> | Date | Mon, 16 Nov 2020 21:32:27 +0100 |
| |
Am 16.11.20 um 18:41 schrieb Lee Jones: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'bo' not described in 'ttm_tt_create' > drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'zero_alloc' not described in 'ttm_tt_create' > drivers/gpu/drm/ttm/ttm_tt.c:83: warning: Function parameter or member 'ttm' not described in 'ttm_tt_alloc_page_directory'
Couldn't we rather describe the missing parameters? Shouldn't be much work.
Regards, Christian.
> > Cc: Christian Koenig <christian.koenig@amd.com> > Cc: Huang Rui <ray.huang@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/gpu/drm/ttm/ttm_tt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > index cfd633c7e7643..da9eeffe0c6d7 100644 > --- a/drivers/gpu/drm/ttm/ttm_tt.c > +++ b/drivers/gpu/drm/ttm/ttm_tt.c > @@ -38,7 +38,7 @@ > #include <drm/drm_cache.h> > #include <drm/ttm/ttm_bo_driver.h> > > -/** > +/* > * Allocates a ttm structure for the given BO. > */ > int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc) > @@ -73,7 +73,7 @@ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc) > return 0; > } > > -/** > +/* > * Allocates storage for pointers to the pages that back the ttm. > */ > static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm)
| |