lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 13/43] drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared header
    On Mon, Nov 16, 2020 at 12:37 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/radeon/radeon_ttm.c:931:5: warning: no previous prototype for ‘radeon_mmap’ [-Wmissing-prototypes]
    > 931 | int radeon_mmap(struct file *filp, struct vm_area_struct *vma)
    > | ^~~~~~~~~~~
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Gareth Hughes <gareth@valinux.com>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/radeon/radeon_drv.c | 2 +-
    > drivers/gpu/drm/radeon/radeon_ttm.h | 1 +
    > 2 files changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
    > index 536b246b9a6aa..2b9deaead99b2 100644
    > --- a/drivers/gpu/drm/radeon/radeon_drv.c
    > +++ b/drivers/gpu/drm/radeon/radeon_drv.c
    > @@ -51,6 +51,7 @@
    > #include <drm/radeon_drm.h>
    >
    > #include "radeon_drv.h"
    > +#include "radeon_ttm.h"
    > #include "radeon.h"
    > #include "radeon_device.h"
    >
    > @@ -125,7 +126,6 @@ extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
    > ktime_t *stime, ktime_t *etime,
    > const struct drm_display_mode *mode);
    > extern bool radeon_is_px(struct drm_device *dev);
    > -int radeon_mmap(struct file *filp, struct vm_area_struct *vma);
    > int radeon_mode_dumb_mmap(struct drm_file *filp,
    > struct drm_device *dev,
    > uint32_t handle, uint64_t *offset_p);
    > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.h b/drivers/gpu/drm/radeon/radeon_ttm.h
    > index 91ea7141bc812..4d7b90ee27740 100644
    > --- a/drivers/gpu/drm/radeon/radeon_ttm.h
    > +++ b/drivers/gpu/drm/radeon/radeon_ttm.h
    > @@ -32,5 +32,6 @@ struct radeon_device;
    >
    > int radeon_ttm_init(struct radeon_device *rdev);
    > void radeon_ttm_fini(struct radeon_device *rdev);
    > +int radeon_mmap(struct file *filp, struct vm_area_struct *vma);
    >
    > #endif /* __RADEON_TTM_H__ */
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-16 20:56    [W:4.089 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site