lkml.org 
[lkml]   [2020]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 01/43] drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s prototype into shared location
    On Mon, Nov 16, 2020 at 12:30 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes]
    > 1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index,
    > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/radeon/atombios_encoders.c | 5 +--
    > drivers/gpu/drm/radeon/radeon_atombios.c | 1 +
    > drivers/gpu/drm/radeon/radeon_atombios.h | 37 ++++++++++++++++++++++
    > 3 files changed, 39 insertions(+), 4 deletions(-)
    > create mode 100644 drivers/gpu/drm/radeon/radeon_atombios.h
    >
    > diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c
    > index cc5ee1b3af84f..683de198e18d9 100644
    > --- a/drivers/gpu/drm/radeon/atombios_encoders.c
    > +++ b/drivers/gpu/drm/radeon/atombios_encoders.c
    > @@ -33,6 +33,7 @@
    > #include <drm/radeon_drm.h>
    >
    > #include "atom.h"
    > +#include "radeon_atombios.h"
    > #include "radeon.h"
    > #include "radeon_asic.h"
    > #include "radeon_audio.h"
    > @@ -296,10 +297,6 @@ static void radeon_atom_backlight_exit(struct radeon_encoder *encoder)
    >
    > #endif
    >
    > -/* evil but including atombios.h is much worse */
    > -bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index,
    > - struct drm_display_mode *mode);
    > -
    > static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
    > const struct drm_display_mode *mode,
    > struct drm_display_mode *adjusted_mode)
    > diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
    > index 5d25917251892..71bf2ed172697 100644
    > --- a/drivers/gpu/drm/radeon/radeon_atombios.c
    > +++ b/drivers/gpu/drm/radeon/radeon_atombios.c
    > @@ -34,6 +34,7 @@
    > #include "atom.h"
    > #include "atom-bits.h"
    > #include "radeon_asic.h"
    > +#include "radeon_atombios.h"
    >
    > extern void
    > radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum,
    > diff --git a/drivers/gpu/drm/radeon/radeon_atombios.h b/drivers/gpu/drm/radeon/radeon_atombios.h
    > new file mode 100644
    > index 0000000000000..b7c76920feb7d
    > --- /dev/null
    > +++ b/drivers/gpu/drm/radeon/radeon_atombios.h
    > @@ -0,0 +1,37 @@
    > +/* radeon_atombios.h -- Private header for radeon driver -*- linux-c -*-
    > + *
    > + * Copyright 2007-8 Advanced Micro Devices, Inc.
    > + * Copyright 2008 Red Hat Inc.
    > + *
    > + * Permission is hereby granted, free of charge, to any person obtaining a
    > + * copy of this software and associated documentation files (the "Software"),
    > + * to deal in the Software without restriction, including without limitation
    > + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
    > + * and/or sell copies of the Software, and to permit persons to whom the
    > + * Software is furnished to do so, subject to the following conditions:
    > + *
    > + * The above copyright notice and this permission notice shall be included in
    > + * all copies or substantial portions of the Software.
    > + *
    > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
    > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
    > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
    > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
    > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
    > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
    > + * OTHER DEALINGS IN THE SOFTWARE.
    > + *
    > + * Authors: Dave Airlie
    > + * Alex Deucher
    > + */
    > +
    > +#ifndef __RADEON_ATOMBIOS_H__
    > +#define __RADEON_ATOMBIOS_H__
    > +
    > +struct drm_display_mode;
    > +struct radeon_device;
    > +
    > +bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index,
    > + struct drm_display_mode *mode);
    > +
    > +#endif /* __RADEON_ATOMBIOS_H__ */
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-16 20:27    [W:3.951 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site