Messages in this thread | | | Date | Mon, 16 Nov 2020 16:24:40 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf vendor events: Update Skylake client events to v50 |
| |
Em Mon, Nov 16, 2020 at 11:12:30AM -0800, Ian Rogers escreveu: > On Mon, Nov 16, 2020 at 9:05 AM Arnaldo Carvalho de Melo <acme@kernel.org> > wrote: > > > Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu: > > > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao <yao.jin@linux.intel.com> > > wrote: > > > > >> Signed-off-by: Jin Yao <yao.jin@linux.intel.com> > > > > > > > > > > It seems not applied to acme/perf/core cleanly. > > > > > > > > > > Thanks, > > > > > Namhyung > > > > > > > > > > > > > It seems the patch mail is truncated. :( > > > > > > > > I attach the patch file in the mail. Sorry for inconvenience. > > > > > > I've checked it fixed the perf test on my laptop (skylake). > > > > > > Tested-by: Namhyung Kim <namhyung@kernel.org> > > > > Thanks, applied. > > > > - Arnaldo > > > > Nit, as the code is generated, would it be possible to add the commands to > regenerate it? > > E.g. Using the code in: > https://github.com/intel/event-converter-for-linux-perf > And extracted perfmon_server_events_v1.4.tar from: > https://download.01.org/perfmon/ > run: > json-to-perf-json.py --outdir tools/perf/pmu-events/arch/arch/x86/sklylakex > perfmon/SKX/skylakex_core_v1.24.json
> Looking at the download.01.org/perfmon json there are files > like skylakex_fp_arith_inst_v1.24.json, and how these are incorporated into > these events is less than clear.
You mean change event-converter-for-linux-perf to add this as JSON comments at the start of the generated files?
- Arnaldo
| |