Messages in this thread | | | Subject | Re: [PATCH v2] soc: ti: pruss: Fix wrong check against *get_match_data return value | From | Suman Anna <> | Date | Mon, 16 Nov 2020 13:11:57 -0600 |
| |
On 11/16/20 1:06 PM, santosh.shilimkar@oracle.com wrote: > On 11/16/20 9:31 AM, Suman Anna wrote: >> Hi Santosh, >> >> On 11/16/20 11:22 AM, Grzegorz Jaszczyk wrote: >>> Since the of_device_get_match_data() doesn't return error code, remove >>> wrong IS_ERR test. Proper check against NULL pointer is already done >>> later before usage: if (data && data->...). >>> >>> Additionally, proceeding with empty device data is valid (e.g. in case >>> of "ti,am3356-pruss"). >>> >>> Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX") >>> Reported-by: Wei Yongjun <weiyongjun1@huawei.com> >>> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> >>> Acked-by: Suman Anna <s-anna@ti.com> >> >> Can you please pick this up for 5.10-rc's? >> > Nothing is broken so I will just add these for next merge window.
Yeah, that is fine as well. Thanks Santosh.
regards Suman
| |