Messages in this thread | | | Date | Mon, 16 Nov 2020 18:59:03 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack |
| |
On Fri, Nov 13, 2020 at 02:06:29PM -0800, Tim Harvey wrote:
> asserted? I'm also wondering if my issue is that I currently have the > interrupt registered as such:
> ret = devm_regmap_add_irq_chip(dev, gsc->regmap, client->irq, > IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_FALLING, 0, &gsc_irq_chip, > &irq_data);
> Perhaps this should be IRQF_TRIGGER_LOW as the device will not > de-assert its IRQ# until all source bits are cleared.
That's clearly an active low interrupt, it will break things if it's registered as edge triggered. [unhandled content-type:application/pgp-signature] | |