| Subject | Re: [PATCH RFC 08/12] vdpa_sim: use kvmalloc to allocate vdpasim->buffer | From | Jason Wang <> | Date | Mon, 16 Nov 2020 12:19:17 +0800 |
| |
On 2020/11/13 下午9:47, Stefano Garzarella wrote: > The next patch will make the buffer size configurable from each > device. > Since the buffer could be larger than a page, we use kvmalloc() > instead of kmalloc(). > > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
> --- > drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c > index 9c29c2013661..bd034fbf4683 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > @@ -223,7 +223,7 @@ struct vdpasim *vdpasim_create(struct vdpasim_init_attr *attr) > if (!vdpasim->iommu) > goto err_iommu; > > - vdpasim->buffer = kmalloc(PAGE_SIZE, GFP_KERNEL); > + vdpasim->buffer = kvmalloc(PAGE_SIZE, GFP_KERNEL); > if (!vdpasim->buffer) > goto err_iommu; > > @@ -495,7 +495,7 @@ static void vdpasim_free(struct vdpa_device *vdpa) > struct vdpasim *vdpasim = vdpa_to_sim(vdpa); > > cancel_work_sync(&vdpasim->work); > - kfree(vdpasim->buffer); > + kvfree(vdpasim->buffer); > if (vdpasim->iommu) > vhost_iotlb_free(vdpasim->iommu); > kfree(vdpasim->vqs);
|