| Date | Sat, 14 Nov 2020 10:53:33 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 02/16] mm/shmem: Use pagevec_lookup in shmem_unlock_mapping |
| |
On Thu, Nov 12, 2020 at 09:26:27PM +0000, Matthew Wilcox (Oracle) wrote: > The comment shows that the reason for using find_get_entries() is now > stale; find_get_pages() will not return 0 if it hits a consecutive run > of swap entries, and I don't believe it has since 2011. pagevec_lookup() > is a simpler function to use than find_get_pages(), so use it instead. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Reviewed-by: Jan Kara <jack@suse.cz> > Reviewed-by: William Kucharski <william.kucharski@oracle.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
|