Messages in this thread | | | Date | Sat, 14 Nov 2020 20:22:02 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH 7/9] iio: adc: at91_adc: use devm_input_allocate_device |
| |
On 14/11/2020 17:13:40+0000, Jonathan Cameron wrote: > On Fri, 13 Nov 2020 22:26:48 +0100 > Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > > > Use devm_input_allocate_device to allocate the input device to simplify the > > error and remove paths. > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > This one I'm less keen on. Whilst it's obviously not a problem in > this particular case I'd ideally like to keep the remove order > as the exact reverse of probe - that makes it easy to review changes > quickly. > > Now, you could easily enough make this fine by using devm for the > other items that happen before this (dev_add_action_or_reset needed > in a few cases). >
Right, I'll drop it for now.
| |