lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions
    From
    Date
    On 11/12/20 1:37 AM, Christoph Hellwig wrote:
    > On Wed, Nov 11, 2020 at 07:04:37PM -0600, Tyrel Datwyler wrote:
    >> Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve
    >> values from vhost->login_buf.resp buffer. This is the MAD response
    >> buffer from the VIOS and as such any multi-byte non-string values are in
    >> big endian format.
    >>
    >> Byte swap these values to host cpu endian format for better human
    >> readability.
    >
    > The whole series creates tons of pointlessly over 80 char lines.
    > Please do a quick fixup.
    >

    The checkpatch script only warns at 100 char lines these days. To be fair though
    I did have two lines go over that limit by a couple characters, there are a
    couple commit log typos, and I had an if keyword with no space after before the
    opening parenthesis. So, I'll happily re-spin.

    However, for my info going forward is the SCSI subsystem sticking to 80 char
    lines as a hard limit?

    -Tyrel

    \
     
     \ /
      Last update: 2020-11-13 20:40    [W:4.145 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site