lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] KVM: SVM: Use a separate vmcb for the nested L2 guest
Date
On 13/10/20 03:33, Sean Christopherson wrote:
>> + svm->vmcb = svm->vmcb01;
>> + svm->vmcb_pa = svm->vmcb01_pa;
> I very highly recommend adding a helper to switch VMCB. Odds are very good
> there will be more than just these two lines of boilerplate code for changing
> the active VMCB.

Yes, probably we can make svm->vmcb01 and svm->vmcb02 something like
VMX's struct loaded_vmcs:

struct kvm_vmcb {
void *vmcb;
unsigned long pa;
}

I don't expect a lot more to happen due to SVM having no need for
caching, so for now I think it's okay.

I have other comments for which I'll reply to the patch itself.

Paolo

\
 
 \ /
  Last update: 2020-11-13 18:36    [W:1.224 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site