lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 11/40] drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and extra params
    On Fri, Nov 13, 2020 at 8:50 AM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'freq' not described in 'amdgpu_pll_compute'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'fb_div_p' not described in 'amdgpu_pll_compute'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'frac_fb_div_p' not described in 'amdgpu_pll_compute'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'ref_div_p' not described in 'amdgpu_pll_compute'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter or member 'post_div_p' not described in 'amdgpu_pll_compute'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:317: warning: Excess function parameter 'encoder' description in 'amdgpu_pll_get_shared_nondp_ppll'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 10 +++++-----
    > 1 file changed, 5 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
    > index 1f2305b7bd135..f2e20666c9c1b 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
    > @@ -102,11 +102,12 @@ static void amdgpu_pll_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_
    > * amdgpu_pll_compute - compute PLL paramaters
    > *
    > * @pll: information about the PLL
    > + * @freq: requested frequency
    > * @dot_clock_p: resulting pixel clock
    > - * fb_div_p: resulting feedback divider
    > - * frac_fb_div_p: fractional part of the feedback divider
    > - * ref_div_p: resulting reference divider
    > - * post_div_p: resulting reference divider
    > + * @fb_div_p: resulting feedback divider
    > + * @frac_fb_div_p: fractional part of the feedback divider
    > + * @ref_div_p: resulting reference divider
    > + * @post_div_p: resulting reference divider
    > *
    > * Try to calculate the PLL parameters to generate the given frequency:
    > * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div)
    > @@ -308,7 +309,6 @@ int amdgpu_pll_get_shared_dp_ppll(struct drm_crtc *crtc)
    > * amdgpu_pll_get_shared_nondp_ppll - return the PPLL used by another non-DP crtc
    > *
    > * @crtc: drm crtc
    > - * @encoder: drm encoder
    > *
    > * Returns the PPLL (Pixel PLL) used by another non-DP crtc/encoder which can
    > * be shared (i.e., same clock).
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-13 18:18    [W:4.550 / U:0.752 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site