lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 08/40] drm/amd/amdgpu/amdgpu_ib: Fix some incorrect/incomplete function documentation
    On Fri, Nov 13, 2020 at 8:50 AM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function parameter or member 'adev' not described in 'amdgpu_ib_get'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function parameter or member 'vm' not described in 'amdgpu_ib_get'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Function parameter or member 'pool_type' not described in 'amdgpu_ib_get'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:66: warning: Excess function parameter 'ring' description in 'amdgpu_ib_get'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:125: warning: Function parameter or member 'ring' not described in 'amdgpu_ib_schedule'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:125: warning: Function parameter or member 'job' not described in 'amdgpu_ib_schedule'
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:125: warning: Excess function parameter 'adev' description in 'amdgpu_ib_schedule'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Sumit Semwal <sumit.semwal@linaro.org>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Cc: linux-media@vger.kernel.org
    > Cc: linaro-mm-sig@lists.linaro.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex


    > ---
    > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 ++++--
    > 1 file changed, 4 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
    > index 2f53fa0ae9a62..c69af9b86cc60 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
    > @@ -52,8 +52,10 @@
    > /**
    > * amdgpu_ib_get - request an IB (Indirect Buffer)
    > *
    > - * @ring: ring index the IB is associated with
    > + * @adev: amdgpu_device pointer
    > + * @vm: amdgpu_vm pointer
    > * @size: requested IB size
    > + * @pool_type: IB pool type (delayed, immediate, direct)
    > * @ib: IB object returned
    > *
    > * Request an IB (all asics). IBs are allocated using the
    > @@ -101,7 +103,7 @@ void amdgpu_ib_free(struct amdgpu_device *adev, struct amdgpu_ib *ib,
    > /**
    > * amdgpu_ib_schedule - schedule an IB (Indirect Buffer) on the ring
    > *
    > - * @adev: amdgpu_device pointer
    > + * @ring: ring index the IB is associated with
    > * @num_ibs: number of IBs to schedule
    > * @ibs: IB objects to schedule
    > * @f: fence created during this submission
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-13 18:17    [W:4.084 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site