lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 04/17] iommu/hyperv: don't setup IRQ remapping when running as root
On Thu, Nov 12, 2020 at 04:27:14PM +0100, Vitaly Kuznetsov wrote:
> Wei Liu <wei.liu@kernel.org> writes:
>
> > The IOMMU code needs more work. We're sure for now the IRQ remapping
> > hooks are not applicable when Linux is the root.
>
> Super-nitpick: I would suggest we always say 'root partition' as 'root'
> has a 'slightly different' meaning in Linux and this commit message may
> sound confusing to an unprepared reader.

Fixed.

>
> >
> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > Acked-by: Joerg Roedel <jroedel@suse.de>
> > ---
> > drivers/iommu/hyperv-iommu.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> > index e09e2d734c57..8d3ce3add57d 100644
> > --- a/drivers/iommu/hyperv-iommu.c
> > +++ b/drivers/iommu/hyperv-iommu.c
> > @@ -20,6 +20,7 @@
> > #include <asm/io_apic.h>
> > #include <asm/irq_remapping.h>
> > #include <asm/hypervisor.h>
> > +#include <asm/mshyperv.h>
> >
> > #include "irq_remapping.h"
> >
> > @@ -143,7 +144,7 @@ static int __init hyperv_prepare_irq_remapping(void)
> > int i;
> >
> > if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> > - !x2apic_supported())
> > + !x2apic_supported() || hv_root_partition)
> > return -ENODEV;
> >
> > fn = irq_domain_alloc_named_id_fwnode("HYPERV-IR", 0);
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Thanks.

Wei.

>
> --
> Vitaly
>

\
 
 \ /
  Last update: 2020-11-13 15:53    [W:0.204 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site