Messages in this thread | | | From | Dwaipayan Ray <> | Date | Fri, 13 Nov 2020 19:47:35 +0530 | Subject | Re: [PATCH RFC] checkpatch: add new cases to commit handling |
| |
On Fri, Nov 13, 2020 at 7:31 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > On Fri, Nov 13, 2020 at 2:37 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > > On Fri, Nov 13, 2020 at 1:31 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote: > > > > > > Commit extraction in checkpatch fails in some cases. > > > One of the most common false positives is a split line > > > between "commit" and the git SHA of the commit. > > > > > > Improve commit handling to reduce false positives. > > > > > > Improvements: > > > - handle split line between commit and git SHA of commit. > > > - fix handling of split commit description. > > > > > > A quick evaluation of 50k commits from v5.4 showed that > > > the GIT_COMMIT_ID errors dropped from 1032 to 897. Most > > > of these were split lines between commit and its hash. > > > > > > > Can you send me the file of the evaluation, e.g., all contexts (two > > lines above and two lines below) around the warned line in the commits > > where the GIT_COMMIT_ID dropped? > > > > Then, I can do a quick sanity check as well. > > > > Thanks, Dwaipayan; I checked your file sent off-list and it looks good > to not report on those cases. > > Maybe we can now check the remaining 900 cases once again; are they > all true positives or is there still a big false positive class? > > Lukas
Hi, I had roughly gone through the list and most of them are true positives. But there are two particular cases which may be false:
1) References: tag. (I don't know if it is a proper convention). There were about 50 of these:
References: 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy")
But it is non uniform. Some commits use this tag to refer to links also.
2) Quotes inside commit title. (apart from the main enclosing quotes) I think by design checkpatch doesn't handle this case.
Thanks, Dwaipayan.
| |