Messages in this thread | | | Subject | Re: [PATCH RESEND 0/4] regulator: debugging and fixing supply deps | From | Ahmad Fatoum <> | Date | Fri, 13 Nov 2020 12:22:53 +0100 |
| |
CC += linux-stm32 as other STM32MP1 boards are also affected.
On 11/13/20 12:19 PM, Ahmad Fatoum wrote: > Hello Michał, > > On 11/13/20 1:20 AM, Michał Mirosław wrote: >> It turns out that commit aea6cb99703e ("regulator: resolve supply >> after creating regulator") exposed a number of issues in regulator >> initialization and introduced a memory leak of its own. One uncovered >> problem was already fixed by cf1ad559a20d ("regulator: defer probe when >> trying to get voltage from unresolved supply"). This series fixes the >> remaining ones and adds a two debugging aids to help in the future. >> >> The final patch adds a workaround to preexisting problem occurring with >> regulators that have the same name as its supply_name. This worked >> before by accident, so might be worth backporting. The error message is >> left on purpose so that these configurations can be detected and fixed. >> >> (The first two patches are resends from Nov 5). >> >> (Series resent because of wrong arm-kernel ML address.) > > lxa-mc1 (STM32MP1 board with STPMIC) now manages to boot again with following > new warning: > > stpmic1-regulator 5c002000.i2c:stpmic@33:regulators: Supply for VREF_DDR > > So for the whole series, > Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> # stpmic1 > > Thanks! > Ahmad > >> >> Michał Mirosław (4): >> regulator: fix memory leak with repeated set_machine_constraints() >> regulator: debug early supply resolving >> regulator: avoid resolve_supply() infinite recursion >> regulator: workaround self-referent regulators >> >> drivers/regulator/core.c | 40 ++++++++++++++++++++++++---------------- >> 1 file changed, 24 insertions(+), 16 deletions(-) >> >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |