lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()
    Date
    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    ---
    drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
    index a2dbbb9..0ee421f 100644
    --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
    +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
    @@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
    BRCMF_WSEC_MAX_PSK_LEN);
    else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
    /* clean up user-space RSNE */
    - if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
    + err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
    + if (err) {
    bphy_err(drvr, "failed to clean up user-space RSNE\n");
    goto done;
    }
    --
    2.9.5
    \
     
     \ /
      Last update: 2020-11-13 07:27    [W:5.096 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site