lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mfd: kempld-core: Check for DMI definition before ACPI
On Tue, 10 Nov 2020, Guenter Roeck wrote:

> On Tue, Nov 10, 2020 at 03:23:21PM +0000, Michael Brunner wrote:
> > Change the detection order to priorize DMI table entries over available
> > ACPI entries.
> >
> > This makes it more easy for product developers to patch product specific
> > handling into the driver.
> > Furthermore it allows to simplify the implementation a bit and
> > especially to remove the need to force synchronous probing.
> >
> > Based on the following commit introduced with v5.10-rc1:
> > commit e8299c7313af ("mfd: Add ACPI support to Kontron PLD driver")
> >
> > v2: Fixed coding style as suggested by Guenther Roeck
> >
>
> Nit: change logs should be after '---'.

Right. Please submit a v3 fixing this.

> Other than that,
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2020-11-13 11:15    [W:0.136 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site