Messages in this thread Patch in this message | | | From | Youling Tang <> | Subject | [PATCH 1/2] arm: Fix memleak in omap2xxx_clkt_vps_init | Date | Sat, 14 Nov 2020 12:06:58 +0800 |
| |
If the clk_register fails, we should free hw before function returns to prevent memleak.
Signed-off-by: Youling Tang <tangyouling@loongson.cn> --- arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c index 2a3e722..70892b3 100644 --- a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c +++ b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c @@ -244,6 +244,12 @@ void omap2xxx_clkt_vps_init(void) hw->hw.init = &init; clk = clk_register(NULL, &hw->hw); + if (IS_ERR(clk)) { + printk(KERN_ERR "Failed to register clock\n"); + kfree(hw); + return; + } + clkdev_create(clk, "cpufreq_ck", NULL); return; cleanup: -- 2.1.0
| |