lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] locking-selftest: add option to proceed through unexpected failures
Date
Locking selftest is currently (v.5.10-rc3) seeing 14 unexpected failures.
Add option to not disable debug_locks, so as to let it reveal any
locking flaws in new unrelated work.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/locking-selftest.c | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index a899b3f0e2e5..87889bcf3232 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -41,6 +41,20 @@ static int __init setup_debug_locks_verbose(char *str)

__setup("debug_locks_verbose=", setup_debug_locks_verbose);

+/*
+ * proceed thru debug fails, leave debugging enabled
+ */
+static unsigned int debug_locks_proceed;
+
+static int __init setup_debug_locks_proceed(char *str)
+{
+ get_option(&str, &debug_locks_proceed);
+
+ return 1;
+}
+
+__setup("debug_locks_proceed=", setup_debug_locks_proceed);
+
#define FAILURE 0
#define SUCCESS 1

@@ -2480,9 +2494,10 @@ void locking_selftest(void)

if (unexpected_testcase_failures) {
printk("-----------------------------------------------------------------\n");
- debug_locks = 0;
- printk("BUG: %3d unexpected failures (out of %3d) - debugging disabled! |\n",
- unexpected_testcase_failures, testcase_total);
+ debug_locks = debug_locks_proceed;
+ printk("BUG: %3d unexpected failures (out of %3d) - debugging %s! |\n",
+ unexpected_testcase_failures, testcase_total,
+ (!debug_locks_proceed) ? "disabled" : "proceeding anyway");
printk("-----------------------------------------------------------------\n");
} else if (expected_testcase_failures && testcase_successes) {
printk("--------------------------------------------------------\n");
--
2.28.0
\
 
 \ /
  Last update: 2020-11-14 00:02    [W:0.032 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site