lkml.org 
[lkml]   [2020]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] kernel-doc: Handle function typedefs without asterisks
On Fri, Nov 13, 2020 at 03:21:06PM -0700, Jonathan Corbet wrote:
> On Fri, 30 Oct 2020 15:47:13 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> > From: Eduardo Habkost <ehabkost@redhat.com>
> >
> > Example of typedef that was not parsed by kernel-doc:
> >
> > typedef void (ObjectUnparent)(Object *obj);
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> So as you've undoubtedly noticed, reading those kernel-doc regexes is ... a
> wee bit on the painful side. Trying to compare two of them in a patch to
> figure out what you have done is even worse. I suspect we want these
> patches, but can you please supply a changelog that describes the change?

Better ... can we have a test suite for the regexes and make patches to
them include updates to the test suite? They have clearly passed the
point of human understanding ;-)

\
 
 \ /
  Last update: 2020-11-13 23:39    [W:0.074 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site