Messages in this thread | | | From | Song Liu <> | Subject | Re: [PATCH bpf-next v5 31/34] bpf: eliminate rlimit-based memory accounting for bpf local storage maps | Date | Fri, 13 Nov 2020 20:53:25 +0000 |
| |
> On Nov 13, 2020, at 11:33 AM, Roman Gushchin <guro@fb.com> wrote: > > On Fri, Nov 13, 2020 at 10:14:48AM -0800, Song Liu wrote: >> >> >>> On Nov 12, 2020, at 2:15 PM, Roman Gushchin <guro@fb.com> wrote: >>> >>> Do not use rlimit-based memory accounting for bpf local storage maps. >>> It has been replaced with the memcg-based memory accounting. >>> >>> Signed-off-by: Roman Gushchin <guro@fb.com> >>> --- >>> kernel/bpf/bpf_local_storage.c | 11 ----------- >>> 1 file changed, 11 deletions(-) >>> >>> diff --git a/kernel/bpf/bpf_local_storage.c b/kernel/bpf/bpf_local_storage.c >>> index fd4f9ac1d042..3b0da5a04d55 100644 >>> --- a/kernel/bpf/bpf_local_storage.c >>> +++ b/kernel/bpf/bpf_local_storage.c >> >> Do we need to change/remove mem_charge() and mem_uncharge() in >> bpf_local_storage.c? I didn't find that in the set. > > No, those are used for per-socket memory limits (see sk_storage_charge() > and omem_charge()).
I see. Thanks for the explanation.
Acked-by: Song Liu <songliubraving@fb.com>
| |