Messages in this thread | | | From | Roman Kiryanov <> | Date | Fri, 13 Nov 2020 12:39:54 -0800 | Subject | Re: [PATCH] drivers: staging: retire drivers/staging/goldfish |
| |
Hi Greg, thank you for looking into this.
On Thu, Nov 12, 2020 at 11:44 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Thu, Nov 12, 2020 at 03:49:07PM -0800, rkir@google.com wrote: > > From: Roman Kiryanov <rkir@google.com> > > > > Android Studio Emulator (goldfish) migrated > > to Intel HDA. > > When was that?
At least one year, our 4.14 kernel does not include this option into the defconfig, 4.4 includes it, but probably we don't need it.
> What about the other goldfish drivers?
There are only four goldfish divers we use in R: goldfish_pipe, goldfish_battery, goldfish_sync and goldfish_address_space. The goldfish_battery one is fully upstreamed but I need to cleanup Kconfig's (this is why I sent this patch). The goldfish_pipe one has off-tree changes. The goldfish_sync and goldfish_address_space are not in the kernel tree at all.
The rest can be retired - I will send patches.
The goldfish_pipe driver will be replaced by virtio-vsock and virtio-console eventually. We considered retiring goldfish_battery by switching to ACPI_BATTERY but ACPI is not available (at least in GKI) on arm64.
Regards, Roman.
| |