Messages in this thread | | | Subject | Re: [PATCHv1 4/4] fpga: stratix10-soc: entend driver for bitstream authentication | From | Tom Rix <> | Date | Fri, 13 Nov 2020 12:31:07 -0800 |
| |
On 11/12/20 10:06 AM, richard.gong@linux.intel.com wrote: > From: Richard Gong <richard.gong@intel.com> > > Exten FPGA manager driver to support FPGA bitstream authentication on > Intel SocFPGA platforms. > > Signed-off-by: Richard Gong <richard.gong@intel.com> > --- > drivers/fpga/stratix10-soc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c > index 657a70c..8a59365 100644 > --- a/drivers/fpga/stratix10-soc.c > +++ b/drivers/fpga/stratix10-soc.c > @@ -185,7 +185,10 @@ static int s10_ops_write_init(struct fpga_manager *mgr, > ctype.flags = 0; > if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) { > dev_dbg(dev, "Requesting partial reconfiguration.\n"); > - ctype.flags |= BIT(COMMAND_RECONFIG_FLAG_PARTIAL); > + ctype.flags |= FPGA_MGR_PARTIAL_RECONFIG;
The change does not match the commit log.
Add some comment like..
'Cleanup setting of partial reconfig flag'
to cover the change.
Tom
> + } else if (info->flags & FPGA_MGR_BITSTREM_AUTHENTICATION) { > + dev_dbg(dev, "Requesting bitstream authentication.\n"); > + ctype.flags |= FPGA_MGR_BITSTREM_AUTHENTICATION; > } else { > dev_dbg(dev, "Requesting full reconfiguration.\n"); > }
| |