Messages in this thread | | | Subject | Re: [PATCH] perf vendor events: Update Skylake client events to v50 | From | "Jin, Yao" <> | Date | Fri, 13 Nov 2020 16:12:37 +0800 |
| |
Hi Andi, Ian,
On 11/6/2020 12:21 PM, Namhyung Kim wrote: > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao <yao.jin@linux.intel.com> wrote: >> >> Hi Namhyung, >> >> On 11/6/2020 11:00 AM, Namhyung Kim wrote: >>> Hi, >>> >>> On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote: >>>> - Update Skylake events to v50. >>>> - Update Skylake JSON metrics from TMAM 4.0. >>>> - Fix the issue in DRAM_Parallel_Reads >>>> - Fix the perf test warning >>>> >>>> Before: >>>> >>>> root@kbl-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1 >>>> event syntax error: '{arb/event=0x80,umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W' >>>> \___ unknown term 'thresh' for pmu 'uncore_arb' >>>> >>>> valid terms: event,edge,inv,umask,cmask,config,config1,config2,name,period,percore >>>> >>>> Initial error: >>>> event syntax error: '..umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W' >>>> \___ Cannot find PMU `arb'. Missing kernel support? >>>> >>>> root@kbl-ppc:~# perf test metrics >>>> 10: PMU events : >>>> 10.3: Parsing of PMU event table metrics : Skip (some metrics failed) >>>> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok >>>> 67: Parse and process metrics : Ok >>>> >>>> After: >>>> >>>> root@kbl-ppc:~# perf stat -M MEM_Parallel_Reads -- sleep 1 >>>> >>>> Performance counter stats for 'system wide': >>>> >>>> 4,951,646 arb/event=0x80,umask=0x2/ # 26.30 MEM_Parallel_Reads (50.04%) >>>> 188,251 arb/event=0x80,umask=0x2,cmask=1/ (49.96%) >>>> >>>> 1.000867010 seconds time elapsed >>>> >>>> root@kbl-ppc:~# perf test metrics >>>> 10: PMU events : >>>> 10.3: Parsing of PMU event table metrics : Ok >>>> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok >>>> 67: Parse and process metrics : Ok >>>> >>>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com> >>> >>> It seems not applied to acme/perf/core cleanly. >>> >>> Thanks, >>> Namhyung >>> >> >> It seems the patch mail is truncated. :( >> >> I attach the patch file in the mail. Sorry for inconvenience. > > I've checked it fixed the perf test on my laptop (skylake). > > Tested-by: Namhyung Kim <namhyung@kernel.org> > > Thanks, > Namhyung >
Can I get ACK for this patch?
It's mainly for fixing the perf-test issue and MEM_Parallel_Reads issue.
Thanks Jin Yao
| |