Messages in this thread | | | Date | Thu, 12 Nov 2020 12:21:06 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/3 v5] ftrace: Have the callbacks receive a struct ftrace_regs instead of pt_regs |
| |
On Thu, 12 Nov 2020 22:38:53 +0530 "Naveen N. Rao" <naveen.n.rao@linux.ibm.com> wrote:
> > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h > > index 629abaf25681..be73350955e4 100644 > > --- a/include/linux/kprobes.h > > +++ b/include/linux/kprobes.h > > @@ -345,7 +345,7 @@ static inline void wait_for_kprobe_optimizer(void) > > { } > > #endif /* CONFIG_OPTPROBES */ > > #ifdef CONFIG_KPROBES_ON_FTRACE > > extern void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip, > > - struct ftrace_ops *ops, struct pt_regs *regs); > > + struct ftrace_ops *ops, struct ftrace_regs *fregs); > > This breaks the build on non-x86 architectures that support > KPROBES_ON_FTRACE.
I thought I ran this on my cross tests build. :-/
But it seems this only updated x86. I thought I updated all the other archs, but it appears that I didn't. I think I may have forgotten to do a git commit properly.
Let me go and fix that (I have to update this series anyway).
Thanks for reporting.
-- Steve
| |