lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v9 44/44] kselftest/arm64: Check GCR_EL1 after context switch
    On Thu, 12 Nov 2020 at 16:59, Alexander Potapenko <glider@google.com> wrote:
    >
    > On Tue, Nov 10, 2020 at 11:12 PM Andrey Konovalov <andreyknvl@google.com> wrote:
    > >
    > > From: Vincenzo Frascino <vincenzo.frascino@arm.com>
    > >
    > > This test is specific to MTE and verifies that the GCR_EL1 register
    > > is context switched correctly.
    > >
    > > It spawn 1024 processes and each process spawns 5 threads. Each thread
    >
    > Nit: "spawns"
    >
    >
    > > + srand(time(NULL) ^ (pid << 16) ^ (tid << 16));
    > > +
    > > + prctl_tag_mask = rand() % 0xffff;
    >
    > Nit: if you want values between 0 and 0xffff you probably want to use
    > bitwise AND.

    Another question would be, is the max here meant to be 0xffff or
    0xffff-1. Because, as-is now, it's 0xffff-1. Only one of them has a
    trivial conversion to bitwise AND ( x % 2^n == x & (2^n - 1) ).

    \
     
     \ /
      Last update: 2020-11-12 17:10    [W:5.575 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site