Messages in this thread | | | Subject | Re: [PATCH V2] clocksource/drivers/cadence_ttc: fix memory leak in ttc_setup_clockevent() | From | Daniel Lezcano <> | Date | Thu, 12 Nov 2020 10:59:33 +0100 |
| |
On 11/11/2020 02:16, Yu Kuai wrote: > If clk_notifier_register() failed, ttc_setup_clockevent() will return > without freeing 'ttcce', which will leak memory. > > Fixes: 70504f311d4b ("clocksource/drivers/cadence_ttc: Convert init function to return error") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yu Kuai <yukuai3@huawei.com> > Reviewed-by: Michal Simek <michal.simek@xilinx.com> > --- > drivers/clocksource/timer-cadence-ttc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/timer-cadence-ttc.c b/drivers/clocksource/timer-cadence-ttc.c > index 80e960602030..32b9560ce408 100644 > --- a/drivers/clocksource/timer-cadence-ttc.c > +++ b/drivers/clocksource/timer-cadence-ttc.c > @@ -426,6 +426,7 @@ static int __init ttc_setup_clockevent(struct clk *clk, > &ttcce->ttc.clk_rate_change_nb); > if (err) { > pr_warn("Unable to register clock notifier.\n"); > + kfree(ttcce); > return err; > }
Please fix the error path by adding a label (eg. out_kfree) and jump to it in case of error everywhere in the function.
out_kfree: kfree(ttcce);
return err;
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |