lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
On Thu, 12 Nov 2020 16:21:49 +1300
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> make coccicheck complains:
>
> ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
>
> It took some staring but I don't think there is a problem because the
> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> are the same thing. But this is confusing for anyone reading the code
> and one less complaint from coccicheck would be nice so lets fix it.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2020-11-12 09:09    [W:0.073 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site