Messages in this thread | | | Date | Thu, 12 Nov 2020 08:50:09 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] w1: w1_therm: Rename conflicting sysfs attribute 'eeprom' to 'eeprom_cmd' |
| |
On Thu, Nov 12, 2020 at 09:49:31AM +0300, Ivan Zaentsev wrote: > Duplicate attribute 'eeprom' is defined in: > 1) Documentation/ABI/testing/sysfs-driver-w1_therm > 2) Documentation/ABI/stable/sysfs-driver-w1_ds28e04 > > Both drivers define an attribute: /sys/bus/w1/devices/.../eeprom > with conflicting behavior. > > Fix by renaming the newer one in w1_therm.c to 'eeprom_cmd'. > > Reported-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Link: https://lore.kernel.org/lkml/20201029152845.6bbb39ce@coco.lan/ > Signed-off-by: Ivan Zaentsev <ivan.zaentsev@wirenboard.ru> > --- > Documentation/ABI/testing/sysfs-driver-w1_therm | 2 +- > Documentation/w1/slaves/w1_therm.rst | 2 +- > drivers/w1/slaves/w1_therm.c | 12 ++++++------ > 3 files changed, 8 insertions(+), 8 deletions(-)
Very nice, thanks for doing this, I'll go queue this up now.
greg k-h
| |