Messages in this thread | | | Date | Thu, 12 Nov 2020 18:46:37 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] reboot: Fix variable assignments in type_store |
| |
On Fri, 13 Nov 2020 02:38:18 +0100 Matteo Croce <mcroce@linux.microsoft.com> wrote:
> At this point, since 'pci' enables BOOT_CF9_FORCE type and > BOOT_CF9_SAFE is not user selectable, should I simply leave only > 'pci'? > This way, we'll have the same set of options for both sysfs and kernel cmdline.
Well, you're the reboot expert ;)
But my $0.02 is yes, let's keep the command-line and sysfs interfaces in sync and cover it all in documentation. It would of course be problematic to change the existing reboot= interface.
I assume that means doing this?
- #define BOOT_CF9_FORCE_STR "cf9_force" + #define BOOT_CF9_FORCE_STR "pci" - #define BOOT_CF9_SAFE_STR "cf9_safe"
| |