lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'
Date


> -----Original Message-----
> From: Lee Jones <lee.jones@linaro.org>
> Sent: Thursday, November 12, 2020 4:33 AM
> To: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> Qiang Zhao <qiang.zhao@nxp.com>; Leo Li <leoyang.li@nxp.com>; Scott
> Wood <scottwood@freescale.com>; act <dmalek@jlc.net>; Dan Malek
> <dan@embeddedalley.com>; Software, Inc <source@mvista.com>; Vitaly
> Bordug <vbordug@ru.mvista.com>; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function
> attribute 'addr'
>
> On Tue, 03 Nov 2020, Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or
> member 'addr' not described in 'cpm_muram_dma'
> > drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter
> 'offset' description in 'cpm_muram_dma'
> >
> > Cc: Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: Li Yang <leoyang.li@nxp.com>
> > Cc: Scott Wood <scottwood@freescale.com>
> > Cc: act <dmalek@jlc.net>
> > Cc: Dan Malek <dan@embeddedalley.com>
> > Cc: "Software, Inc" <source@mvista.com>
> > Cc: Vitaly Bordug <vbordug@ru.mvista.com>
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/soc/fsl/qe/qe_common.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/fsl/qe/qe_common.c
> > b/drivers/soc/fsl/qe/qe_common.c index 75075591f6308..497a7e0fd0272
> > 100644
> > --- a/drivers/soc/fsl/qe/qe_common.c
> > +++ b/drivers/soc/fsl/qe/qe_common.c
> > @@ -231,7 +231,7 @@ EXPORT_SYMBOL(cpm_muram_offset);
> >
> > /**
> > * cpm_muram_dma - turn a muram virtual address into a DMA address
> > - * @offset: virtual address from cpm_muram_addr() to convert
> > + * @addr: virtual address from cpm_muram_addr() to convert
> > */
> > dma_addr_t cpm_muram_dma(void __iomem *addr) {
>
> Any idea who will pick this up?

I can pick them up through my tree, but I haven't created the for-next branch for the next kernel yet. Will look through this series soon. Thanks.

>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services Linaro.org │ Open source
> software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
\
 
 \ /
  Last update: 2020-11-13 00:13    [W:0.301 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site