lkml.org 
[lkml]   [2020]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc'
On Thu, Nov 12, 2020 at 07:00:10PM +0000, Lee Jones wrote:
> The comment about them (also removed) says:
>
> /* fb_rsrc and aper_rsrc aren't really used currently, but still exist
> * in case we decide we need information on the BAR for BSD in the
> * future.
> */
>
> Well that was written 12 years ago in 2008. We are now in the future
> and they are still superfluous. We can always add them again at a
> later date if they are ever required.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/savage/savage_bci.c: In function ‘savage_driver_firstopen’:
> drivers/gpu/drm/savage/savage_bci.c:580:24: warning: variable ‘aper_rsrc’ set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/savage/savage_bci.c:580:15: warning: variable ‘fb_rsrc’ set but not used [-Wunused-but-set-variable]
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---

Thanks, applied to drm-misc-next.

Sam

\
 
 \ /
  Last update: 2020-11-12 20:31    [W:1.122 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site