Messages in this thread | | | Date | Thu, 12 Nov 2020 10:10:26 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR' |
| |
On Thu, 12 Nov 2020 16:26:03 +0100 Simon Horman wrote: > On Thu, Nov 12, 2020 at 10:58:52PM +0800, YueHaibing wrote: > > nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns > > NULL. The NULL test should be removed, also return correct err. > > > > Fixes: 63461a028f76 ("nfp: add the PF driver") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks, this does indeed seem to be the case. > > Reviewed-by: Simon Horman <simon.horman@netronome.com>
Thanks!
I'll drop the fixes tag and apply to net-next, though. Unnecessary NULL-check is hardly a bug.
| |