Messages in this thread | | | Date | Wed, 11 Nov 2020 08:00:27 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR |
| |
On Wed, 11 Nov 2020 05:55:58 -0800 Richard Cochran wrote: > On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: > > > > Following Richard's comments v1 of the patch has to be applied [1]. > > I've also added my Reviewed-by there. > > > > [1] https://lore.kernel.org/patchwork/patch/1334067/ > > +1 > > Jakub, can you please take the original v1 of this patch?
I don't think v1 builds cleanly folks (not 100% sure, cpts is not compiled on x86):
ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV);
ptp_clock is a pointer, ret is an integer, right?
Grygorii, would you mind sending a correct patch in so Wang Qing can see how it's done? I've been asking for a fixes tag multiple times already :(
| |