Messages in this thread | | | Subject | Re: [PATCH 01/13] seqnum_ops: Introduce Sequence Number Ops | From | Shuah Khan <> | Date | Wed, 11 Nov 2020 08:42:10 -0700 |
| |
On 11/10/20 5:20 PM, Kees Cook wrote: > On Tue, Nov 10, 2020 at 03:58:48PM -0700, Shuah Khan wrote: >> Yes we have some instances where unsigned is being used. I considered >> going to unsigned. Changing the API to unsigned has other ramifications >> and cascading changes to current atomic_t usages that are up counters. > > As in, existing callers expect the "read" value to be int? >
Correct. In addition, these values are returned by other functions as signed and it will result in lot of churn to use unsigned.
thanks, -- Shuah
| |