lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpiolib: devres: shrink devm_gpiochip_add_data_with_key()
On Tue, Nov 10, 2020 at 11:42 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> If all we want to manage is a single pointer, there's no need to
> manually allocate and add a new devres. We can simply use
> devm_add_action_or_reset() and shrink the code by a good bit.

Yes, it is possible to convert all one-function-based devm_*()
wrappers to use this approach.

The problem is, it will call the release() function on error which is
new (and probably undesired) behaviour.
I suppose you meant devm_add_action() here.


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-11-11 16:03    [W:0.068 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site