Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 11 Nov 2020 15:53:04 +0100 | Subject | Re: [PATCH] pinctrl: pinctrl-at91-pio4: Set irq handler and data in one go |
| |
On Tue, Nov 10, 2020 at 10:08 AM Nicolas Ferre <nicolas.ferre@microchip.com> wrote: > On 09/11/2020 at 12:26, Andy Shevchenko wrote: > > On Sun, Nov 8, 2020 at 8:05 PM Martin Kaiser <martin@kaiser.cx> wrote: > >> > >> Replace the two separate calls for setting the irq handler and data with a > >> single irq_set_chained_handler_and_data() call. > > > > Can it be rewritten to use the GPIO core facility of instantiating IRQ chip? > > I have the feeling it's out of scope for this (tiny) patch.
True, but a good suggestion anyways.
If you have a TODO for the AT91 pin controllers I think both using the GPIOLIB_IRQCHIP can cut down the code in these files quite a bit, and probably fix some unknown bugs.
Yours, Linus Walleij
| |