lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS
    On Wed, Nov 11, 2020 at 10:33:29AM +0100, Arnd Bergmann wrote:
    > On Tue, Nov 10, 2020 at 5:21 PM Mike Rapoport <rppt@kernel.org> wrote:
    > > On Tue, Nov 10, 2020 at 12:21:11PM +0100, Arnd Bergmann wrote:
    > > >
    > > > To be on the safe side, we could provoke a compile-time error
    > > > when CONFIG_PHYS_ADDR_T_64BIT is set on a 32-bit
    > > > architecture, but MAX_POSSIBLE_PHYSMEM_BITS is not set.
    > >
    > > Maybe compile time warning and a runtime error in zs_init() if 32 bit
    > > machine has memory above 4G?
    >
    > If the fix is as easy as adding a single line in a header, I think a
    > compile-time
    > error makes it easier, no need to wait for someone to boot a broken
    > system before fixing it.

    Not sure it would be as easy as adding a single line in a header for
    MIPS with it's diversity.

    How about adding a runtime detection like Minchan suggested for
    !MEMORY_HOTPLUG (e.g. MIPS and ARC) and a compile time error otherwise
    (i386, ppc)?

    > Arnd

    --
    Sincerely yours,
    Mike.

    \
     
     \ /
      Last update: 2020-11-11 11:29    [W:2.752 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site