lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization
From
Date
11.11.2020 11:52, Krzysztof Kozlowski пишет:
>> You added this code in patch #8, so adding-and-removing a piece of code
> Correction: you added this in patch #9.
>
> Best regards,
> Krzysztof
>
>
>> is a nice hint that this patch should be before. Don't add new code
>> which later you simplify. Move all bugfixes and all simplifications to
>> beginning of patchset.
>>
>> That's quite similar case to v6 where you put bugfixes in the middle
>> of patchset.
>>

Indeed, I squashed a similar change in the T124 patch #13, but forgot to
squash it for the T30.

\
 
 \ /
  Last update: 2020-11-11 10:01    [W:0.115 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site