Messages in this thread | | | Subject | Re: [EXTERNAL] [tip: x86/apic] x86/io_apic: Cleanup trigger/polarity helpers | From | David Woodhouse <> | Date | Wed, 11 Nov 2020 08:16:46 +0000 |
| |
On Tue, 2020-11-10 at 23:48 +0100, Thomas Gleixner wrote: > + * IRQCHIP_MSI_EXTID The MSI message created for this chip can > + * have an otherwise forbidden extended ID
If we're going to do that then we could ditch the separate iommu_compose_msi_msg() function too, right?
But actually I'd be more inclined to fix this differently, in a way that doesn't still leave AMD's iommu_init_intcapxt() having to set use irq_set_affinity_notifier() to update its own registers. That's icky.
Given that this is *its* irqdomain in the first place, it should just sit at ->set_affinity() for itself, and call its parent as usual without having to use a notifier.
We should also leave it using the basic PCI MSI support in the case where the IOMMU doesn't have XTSUP support. It doesn't need its own irqdomain for that.
[unhandled content-type:application/x-pkcs7-signature] | |