lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver
On Wed, Nov 11, 2020 at 07:21:07AM +0000, Yuan, Perry wrote:
> > > + status = acpi_evaluate_object(NULL, ACPI_PRIVACY_EC_ACK, NULL,
> > NULL);
> > > + if (ACPI_FAILURE(status)) {
> > > + dev_err(led_cdev->dev, "Error setting privacy audio EC ack
> > value: %d\n",status);
> > > + return -EIO;
> > > + }
> > > + return 0;
> > > +}
> >
> > What's actually being set here? You don't seem to be passing any arguments.
>
> Yes, it is a EC ack notification without any arguments needed.

I'm confused why it's being exposed as an LED device in that case -
there's an expectation that this is something that actually controls a
real LED, which means responding to state. Are you able to share the
acpidump of a machine with this device?

--
Matthew Garrett | mjg59@srcf.ucam.org

\
 
 \ /
  Last update: 2020-11-11 08:26    [W:0.064 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site