lkml.org 
[lkml]   [2020]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 05/24] dt-bindings: mediatek: Add binding for mt8192 IOMMU
    On Wed, Nov 11, 2020 at 08:38:19PM +0800, Yong Wu wrote:
    > This patch adds decriptions for mt8192 IOMMU and SMI.
    >
    > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation
    > table format. The M4U-SMI HW diagram is as below:
    >
    > EMI
    > |
    > M4U
    > |
    > ------------
    > SMI Common
    > ------------
    > |
    > +-------+------+------+----------------------+-------+
    > | | | | ...... | |
    > | | | | | |
    > larb0 larb1 larb2 larb4 ...... larb19 larb20
    > disp0 disp1 mdp vdec IPE IPE
    >
    > All the connections are HW fixed, SW can NOT adjust it.
    >
    > mt8192 M4U support 0~16GB iova range. we preassign different engines
    > into different iova ranges:
    >
    > domain-id module iova-range larbs
    > 0 disp 0 ~ 4G larb0/1
    > 1 vcodec 4G ~ 8G larb4/5/7
    > 2 cam/mdp 8G ~ 12G larb2/9/11/13/14/16/17/18/19/20
    > 3 CCU0 0x4000_0000 ~ 0x43ff_ffff larb13: port 9/10
    > 4 CCU1 0x4400_0000 ~ 0x47ff_ffff larb14: port 4/5
    >
    > The iova range for CCU0/1(camera control unit) is HW requirement.
    >
    > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
    > Reviewed-by: Rob Herring <robh@kernel.org>
    > ---
    > .../bindings/iommu/mediatek,iommu.yaml | 18 +-
    > include/dt-bindings/memory/mt8192-larb-port.h | 240 ++++++++++++++++++
    > 2 files changed, 257 insertions(+), 1 deletion(-)
    > create mode 100644 include/dt-bindings/memory/mt8192-larb-port.h
    >
    > diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
    > index ba6626347381..0f26fe14c8e2 100644
    > --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
    > +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
    > @@ -76,6 +76,7 @@ properties:
    > - mediatek,mt8167-m4u # generation two
    > - mediatek,mt8173-m4u # generation two
    > - mediatek,mt8183-m4u # generation two
    > + - mediatek,mt8192-m4u # generation two
    >
    > - description: mt7623 generation one
    > items:
    > @@ -115,7 +116,11 @@ properties:
    > dt-binding/memory/mt6779-larb-port.h for mt6779,
    > dt-binding/memory/mt8167-larb-port.h for mt8167,
    > dt-binding/memory/mt8173-larb-port.h for mt8173,
    > - dt-binding/memory/mt8183-larb-port.h for mt8183.
    > + dt-binding/memory/mt8183-larb-port.h for mt8183,
    > + dt-binding/memory/mt8192-larb-port.h for mt8192.
    > +
    > + power-domains:
    > + maxItems: 1
    >
    > required:
    > - compatible
    > @@ -133,11 +138,22 @@ allOf:
    > - mediatek,mt2701-m4u
    > - mediatek,mt2712-m4u
    > - mediatek,mt8173-m4u
    > + - mediatek,mt8192-m4u
    >
    > then:
    > required:
    > - clocks
    >
    > + - if:
    > + properties:
    > + compatible:
    > + enum:
    > + - mediatek,mt8192-m4u
    > +
    > + then:
    > + required:
    > + - power-domains
    > +
    > additionalProperties: false
    >
    > examples:
    > diff --git a/include/dt-bindings/memory/mt8192-larb-port.h b/include/dt-bindings/memory/mt8192-larb-port.h
    > new file mode 100644
    > index 000000000000..7437fa62654e
    > --- /dev/null
    > +++ b/include/dt-bindings/memory/mt8192-larb-port.h
    > @@ -0,0 +1,240 @@
    > +/* SPDX-License-Identifier: GPL-2.0-only */
    > +/*
    > + * Copyright (c) 2020 MediaTek Inc.
    > + *
    > + * Author: Chao Hao <chao.hao@mediatek.com>
    > + * Author: Yong Wu <yong.wu@mediatek.com>
    > + */
    > +#ifndef _DTS_IOMMU_PORT_MT8192_H_
    > +#define _DTS_IOMMU_PORT_MT8192_H_

    Not accurate header guard. Shoud be:
    _DT_BINDINGS_MEMORY_MT8192_LARB_PORT_H_

    Probably you copied it from some other Mediatek headers - all of them
    have header guard pointing to different directory.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2020-11-11 22:35    [W:4.315 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site